Enable/disable scheduling topology hints through an env. variable #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
env-var-topo-hints
branch
2 times, most recently
from
6be0388
to
4db2985
Compare
csegarragonz
force-pushed
the
env-var-topo-hints
branch
from
4db2985
to
8bf95d8
Compare
csegarragonz
force-pushed
the
env-var-topo-hints
branch
from
dc8382e
to
65fed71
Compare
Shillaker
requested changes
Dec 1, 2021
| // If topology hints are disabled, unset the provided topology hint | ||
| if (conf.useTopologyHints == "off") { | ||
| topologyHint = faabric::util::SchedulingTopologyHint::NORMAL; | ||
| } |
There was a problem hiding this comment.
I would change this to check if they're requesting anything other than NORMAL, then print a warning if so. We don't want to have this on accidentally.
There was a problem hiding this comment.
Good point. Now we:
- Check if env var set
- If set and hint different than
NORMAL, print a warning and unset.
csegarragonz
commented
Dec 1, 2021
| "Test scheduling hints can be disabled through the config", | ||
| "[scheduler]") | ||
| { | ||
| SchedulingConfig config = { |
There was a problem hiding this comment.
Here I add the new test
|
I every now and then get errors in the sanitised builds unrelated to the changes introduced. Moving the discussion about this offline. |
csegarragonz
requested review from
Shillaker
and removed request for
Shillaker
Shillaker
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR scheduling topology hints may be disabled by setting the environment variable:
NO_TOPOLOGY_HINTS=onin faam's worker.