Fix OpenMP test issue and hanging #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
changed the title
Shillaker
commented
Oct 14, 2021
| ) | ||
| CGroup.cpp | ||
| NetworkNamespace.cpp | ||
| memory.cpp |
There was a problem hiding this comment.
Not sure what our policy on alphatical ordering of caps vs. lowercase. I think caps before lowercase but not too fussed.
csegarragonz
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing regular OpenMP test failures which I think may be a stack overflow in disguise. WAVM is failing internally calling
allocaand producing a segfault then totally bombing out (not even running the crash handler).I've reproduced this locally, and expanding the stack size seems to fix it.
This also reinstates the calls to
FaabricMain::shutdownwhich cause hanging issues infunc_runnerand other executables.The namespace for stuff in
include/systemandsrc/systemisisolation, which should probably besystem, but it's out of scope for this PR to change.