Cmake cleanup Faasm part 1 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2021
Shillaker
reviewed
Oct 26, 2021
Shillaker
reviewed
Oct 26, 2021
Shillaker
reviewed
Oct 26, 2021
Shillaker
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #521
faasm/faabric#164 has to be merged and tagged first, and this needs updating to point to the new faabric-base.
Rather than duplicating docker logic, this bases the faasm-base off the faabric-base container - after the full CMake changeset this makes the dockerfile significantly cleaner, and ensures that the toolchain, cmake and conan versions are in sync with faabric.
This mostly replicates the LLVM13 installation from faabric, and adds a couple of small quality-of-life changes to bin/workon.sh and dev.tools/dev.cc. I also included an update to redis 6, the only thing that had to be changed is explicitly turning off auto-save, otherwise it's fully compatible with redis 5 and works better with newer linux kernels.