Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot and shared memory updates #548

Merged
merged 28 commits into from
Dec 30, 2021
Merged

Snapshot and shared memory updates #548

merged 28 commits into from
Dec 30, 2021

Conversation

Shillaker
Copy link
Collaborator

@Shillaker Shillaker commented Dec 13, 2021

Update to new Faabric snapshots faasm/faabric#176 faasm/faabric#201

Support use of new CPP markup faasm/cpp#71

Closes #545

bin/workon.sh Outdated
export ASAN_OPTIONS="halt_on_error=1"
export LSAN_OPTIONS="suppressions=${PROJ_ROOT}/leak-sanitizer-ignorelist.txt"
export TSAN_OPTIONS="halt_on_error=1:suppressions=${PROJ_ROOT}/thread-sanitizer-ignorelist.txt:history_size=7:second_deadlock_stack=1"
export UBSAN_OPTIONS="print_stacktrace=1:halt_on_error=1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously listed in the dev set-up instructions where it will inevitably rot and must be copy-pasted regularly. Here it's set up by default. Didn't think this was worth a separate PR but can change.

@Shillaker Shillaker changed the title Update to new snapshot mechanism Snapshot and shared memory updates Dec 20, 2021
@Shillaker Shillaker marked this pull request as ready for review December 27, 2021 14:07
Copy link
Collaborator

@csegarragonz csegarragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just minor comments re.std::byte and atomic variables. Also a reminder to finish off and merge the faabric PR first.

include/wavm/WAVMWasmModule.h Show resolved Hide resolved
src/faaslet/Faaslet.cpp Outdated Show resolved Hide resolved
src/runner/func_runner.cpp Show resolved Hide resolved
src/wasm/WasmModule.cpp Show resolved Hide resolved
src/wasm/WasmModule.cpp Show resolved Hide resolved
src/wasm/WasmModule.cpp Outdated Show resolved Hide resolved
src/wasm/WasmModule.cpp Outdated Show resolved Hide resolved
src/wasm/WasmModule.cpp Outdated Show resolved Hide resolved
src/wavm/WAVMModuleCache.cpp Show resolved Hide resolved
tests/test/storage/test_file_descriptor.cpp Show resolved Hide resolved
@Shillaker Shillaker merged commit 11fa8a0 into master Dec 30, 2021
@Shillaker Shillaker deleted the new-snaps branch December 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken OpenMP test
2 participants