-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot and shared memory updates #548
Conversation
bin/workon.sh
Outdated
export ASAN_OPTIONS="halt_on_error=1" | ||
export LSAN_OPTIONS="suppressions=${PROJ_ROOT}/leak-sanitizer-ignorelist.txt" | ||
export TSAN_OPTIONS="halt_on_error=1:suppressions=${PROJ_ROOT}/thread-sanitizer-ignorelist.txt:history_size=7:second_deadlock_stack=1" | ||
export UBSAN_OPTIONS="print_stacktrace=1:halt_on_error=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously listed in the dev set-up instructions where it will inevitably rot and must be copy-pasted regularly. Here it's set up by default. Didn't think this was worth a separate PR but can change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor comments re.std::byte
and atomic variables. Also a reminder to finish off and merge the faabric PR first.
Update to new Faabric snapshots faasm/faabric#176 faasm/faabric#201
Support use of new CPP markup faasm/cpp#71
Closes #545