-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to image build process #553
Conversation
ed2336c
to
a0fdb9b
Compare
5f0ae20
to
d85e941
Compare
d85e941
to
a6f9aac
Compare
a6f9aac
to
fa29f56
Compare
57c1d3f
to
bd0776d
Compare
bd0776d
to
93c0695
Compare
bb93a69
to
d1f1e0c
Compare
d1f1e0c
to
6cd09f2
Compare
.github/workflows/tests.yml
Outdated
- name: "Build codegen - Codegen Shared Obj" | ||
run: inv -r faasmcli/faasmcli dev.cc codegen_shared_obj | ||
run: | | ||
source venv/bin/activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid this repetition with a custom shell or by using alias
for inv
at the start?
I think we can put bash
as the default shell too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set a default shell (that activates the virtual env. before running the command) only for the job that runs the tests.
Note that we can't set the shell as a default for all the workflow as not all jobs run in the same container (thus don't have the venv set, neither they need it).
5dd7ed1
to
b9c90ec
Compare
b9c90ec
to
1d47bde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nice job sorting this all out 👍
In this PR I fix a series of issues I have run into whilst trying to release a new docker image:
site.ENABLE_USER_SITE
in the package'ssetup.py
(i.e. infaasmtools
andfaasmcli
) but this derived in other problems. In the end I have decided to use only virtual environments around (as we do in regular development environments). Note that, to prevent a clash between container and out-of-container builds in thevenv
directory, I make out-of-container builds usevenv-bm
as their virtual environment root.aws-sdk-cpp
. This conan package seems very unstable and fragile, we revert to installing it as anExternalProject
in CMake. I add an interface library + alias to make the replacement transparent.Closes #324