Re-factor SGX directory structure #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclave and tests/enclave
csegarragonz
force-pushed
the
sgx-directories
branch
3 times, most recently
from
67be0a3
to
5d72da6
Compare
csegarragonz
commented
Feb 15, 2022
| @@ -74,9 +73,6 @@ class SGXWAMRWasmModule final : public WasmModule | |||
|
|
|||
| uint8_t* getMemoryBase() override; | |||
|
|
|||
| // TODO: Move in gs/fs | |||
There was a problem hiding this comment.
This class member was defined in attestation.h and was not used.
csegarragonz
force-pushed
the
sgx-directories
branch
from
5d72da6
to
7d8d993
Compare
Shillaker
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
{src,include,tests/tests}/sgxto{src,include,tests/tests}/enclave.attestation.cppandattestation.has they were no longer used.{src,include}/enclavein{src,include}/enclave/{inside,outside}for code that runs inside the enclave and outside, with separateCMakeLists.txt.