Add WAMR support to chain functions by name #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
changed the title
Shillaker
approved these changes
Jun 23, 2022
.github/workflows/tests.yml
Outdated
| # 21/06/2022 - We have disabled the ASAN and TSAN builds as they were | ||
| # consuming upwards of 15 to 20 GB of memory (each). Even on a self- | ||
| # hosted runner this is too much | ||
| sanitiser: [None, Address, Thread, Undefined, Leak] |
There was a problem hiding this comment.
Before merging this, can you remove all sanitiser-related changes into the other sanitiser PR?
There was a problem hiding this comment.
Yes, I'm kinda stuck in the sanitisers PR, so I will work on that first. Then rebase and merge this in.
csegarragonz
force-pushed
the
wamr-chain
branch
from
2300c66
to
2163748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add support to chain functions by name in WAMR. I also add some new un-implemented stubs that I needed to cross-compile functions.