Remove Knative #661
Remove Knative #661
Conversation
csegarragonz
force-pushed
the
remove-knative
branch
from
ed3c015
to
45fcf26
Compare
deploy/k8s/minio.yml.j2
Outdated
| @@ -11,7 +11,7 @@ metadata: | |||
| spec: | |||
| containers: | |||
| - name: minio-main | |||
| image: faasm/minio:0.8.12 | |||
| image: faasm/minio:{{ faasm_version }} | |||
There was a problem hiding this comment.
I thought that, given that we were already templating some of the contents, it was cleaner to also template the faasm version, instead of updating all deployment files every time we bump the code version.
There was a problem hiding this comment.
What other contents are we templating? I had thought I'd removed all templating from the repo as it makes it difficult to review changes, and generally adds more complexity. With this change we're now mixing SGX and non-SGX files again which I'd also quite like to avoid (just to keep the standard non-SGX setup as simple as possible).
| @@ -1,8 +1,8 @@ | |||
| from time import sleep | |||
| from datetime import datetime | |||
There was a problem hiding this comment.
Very messy diff. You may check the raw file here.
deploy/k8s/minio.yml.j2
Outdated
| @@ -11,7 +11,7 @@ metadata: | |||
| spec: | |||
| containers: | |||
| - name: minio-main | |||
| image: faasm/minio:0.8.12 | |||
| image: faasm/minio:{{ faasm_version }} | |||
There was a problem hiding this comment.
What other contents are we templating? I had thought I'd removed all templating from the repo as it makes it difficult to review changes, and generally adds more complexity. With this change we're now mixing SGX and non-SGX files again which I'd also quite like to avoid (just to keep the standard non-SGX setup as simple as possible).
faasmcli/faasmcli/tasks/k8s.py
Outdated
| { | ||
| "name": "AZ_ATTESTATION_PROVIDER_URL", | ||
| "value": "https://faasmattprov.eus2.attest.azure.net", | ||
| }, |
There was a problem hiding this comment.
If we were going to template this stuff, it might be cleaner to keep this in a YAML file, but wrap it with an {% if sgx %} to switch it on or off.
csegarragonz
force-pushed
the
remove-knative
branch
from
4d814e0
to
2a83a8b
Compare
|
@Shillaker do you think we can merge this in? |
In this PR we remove our integration with Knative. We were not using any of Knative's features, and it was making the deployment more complex, slow, and verbose.
In contrast, now we deploy Faasm on a bare k8s cluster. This simplifies the installation and deployment scripts. In summary, deploying/removing Faasm from an existing k8s cluster is a one-liner:
I think I have removed all dangling references to Knative in the org (but I am surely missing some). See related PRs: faasm/experiment-base#51, faasm/experiment-faabric#32, faasm/experiment-openmp#18