-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM 13 #705
Merged
Merged
LLVM 13 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
493f541
to
1014eea
Compare
eb54525
to
3e4b119
Compare
Tests are finally green! 🥲 @Shillaker will request reviews everywhere, you can use this PR's description as guideline. |
…as numpy support is broken
Shillaker
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I bump the Faasm ecossytem to use LLVM 13 all around. This means that we use LLVM 13 to cross-compile to WebAssembly, and to build our WASM runtimes (WAVM and WAMR). The latter is usually the trickiest bit, as WASM runtimes implement optimizations (specially when generating AOT binary code), which are tightly coupled with LLVM. In the case of WAMR, its usually a matter of bumping to the latest commit. In the case of WAVM, it involves some fiddling as the library is less maintained.
Below is a list of the requirements for the merge. I keep it for reference, whenever we upgrade the LLVM version again.
To-Do:
clang-10
: LLVM 13 faabric#285demo/hello
demo/hello
clang-format-10
from all formatting tasksBefore merging:
After merging:
Closes #690
Closes #642 (superseeded)