Patch LLVM #729
Merged
Patch LLVM #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Mar 4, 2023
| @@ -111,7 +111,7 @@ FetchContent_Declare(wavm_ext | |||
|
|
|||
| FetchContent_Declare(wamr_ext | |||
| GIT_REPOSITORY "https://github.com/faasm/wasm-micro-runtime" | |||
| GIT_TAG "135672cab24d877db4ef6933c0ab150351384d51" | |||
| GIT_TAG "a31e5a4fa299c4f8384f40e157b0a928ad0bda1b" | |||
There was a problem hiding this comment.
See this comment (if you have not seen it yet).
csegarragonz
commented
Mar 4, 2023
| @@ -35,7 +35,7 @@ jobs: | |||
| uses: docker/login-action@v2 | |||
| with: | |||
| username: ${{ secrets.DOCKER_USERNAME }} | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
| password: ${{ secrets.DOCKER_TOKEN }} | |||
There was a problem hiding this comment.
As of today, release actions started to fail complaining that we needed to use an access token instead of a password.
Shillaker
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See faasm/cpp#110
In this PR I bump the cpp and python submodules (and their versions) and, given that I make changes to the way we build the LLVM sysroot, I also update the
cpythondep in the base docker image.