MPI support in WAMR #731
Merged
MPI support in WAMR #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Mar 22, 2023
| REG_NATIVE_FUNC(__faasm_await_call, "(i)i"), | ||
| REG_NATIVE_FUNC(__faasm_chain_ptr, "(i$i)i"), | ||
| REG_NATIVE_FUNC(__faasm_pull_state, "(*i)"), |
There was a problem hiding this comment.
I have had to add a couple state functions as well for the MPI tests to pass.
csegarragonz
commented
Mar 22, 2023
| /** | ||
| * Chain a function by function pointer | ||
| */ | ||
| static int32_t __faasm_chain_ptr_wrapper(wasm_exec_env_t exec_env, |
There was a problem hiding this comment.
These two methods were just moved somewhere else in the file to preserve alphabetical order.
csegarragonz
commented
Mar 22, 2023
| { | ||
| SPDLOG_DEBUG("S - poll_oneoff"); | ||
| throw std::runtime_error("poll_oneoff not implemented"); | ||
|
|
||
| WAMRWasmModule* module = getExecutingWAMRModule(); |
There was a problem hiding this comment.
We also needed this function for the MPI tests.
csegarragonz
commented
Mar 23, 2023
| @@ -168,9 +168,10 @@ TEST_CASE_METHOD(OpenMPTestFixture, | |||
| doOmpTestLocal("default_shared"); | |||
| } | |||
|
|
|||
| // 23/03/2023 - This test has become very flaky. | |||
There was a problem hiding this comment.
The fact that this test has started to fail more and more recently also makes me suspicious about the state of WAVM.
Shillaker
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implement MPI support for WAMR.
Recently, execution of large applications in WAVM (e.g. LAMMPS) has been a bit flaky. I have also spotted areas of WAVM's WASI support that are out of sync with the spec. This is increasingly worrying after we have rebased to the latest
wasi-libc.This PR does not mean we are dumping WAVM, but it will help cross-check the origin of certain runtime errors. Also, and this speaks very well to the current WAVM MPI implementation and faasm/faabric split, implementing this was around a day's worth of work.
Most of the code is boilerplate code or WAMR-specific pointer/offset checking/translation. As an implementation note for the future, some of the MPI calls use double-pointers. When registering native symbols in WAMR, one may use the
*character to indicate that a parameter (int32_t) is in fact an offset to WASM memory, and the WAMR runtime converts it into a pointer type, and does the corresponding bound checks so that it is ready to be read-from/written-to. However, if we are dealing with a double pointer, the second pointer is still an offset, not a readily usable native pointer.NB: To run LAMMPS in WAMR we still need a couple more pieces that will come in a subsequent PR.