-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAMR Exception Handling #756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faasm relies on exceptions being propagated from native function calls (i.e. host interface functions called from WASM) to the runtime code. For example, WASM code may call
__faasm_migrate_point
which, in turn, will throw afaabric::util::FunctionMigratedException
. A very simplfied call stack would look something like the following:The previous works fine when the WASM runtime is implemented in C++ (e..g WAVM), as C++ exceptions are correctly propagated. Unfortunately, WAMR is written in C, so exceptions are not correctly propagated, and they are impossible to catch.
To work around this issue, we make use of
setjmp
/longjmp
, inspired from here. This may feel like a big hack, but I don't think there's another way around it. This also means that we need to add a layer of indirection when throwing exceptions from native function calls (and potentially a number ofdynamic_cast
s), but exception throwing and catching is not really performance critical (for now) so we can bear the cost.In the process I homogeneise the interface to execute WASM functions with WAMR (i.e. making call by name and call by pointer use the same low-level functions).