Flush workers through planner #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #767 +/- ##
==========================================
+ Coverage 67.38% 67.43% +0.05%
==========================================
Files 69 69
Lines 7726 7729 +3
==========================================
+ Hits 5206 5212 +6
+ Misses 2520 2517 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump faabric to include faasm/faabric#326.
This means that now worker flush requests (where we clean cached files and machine code) are routed through the planner. Users then send an HTTP request to the planner, and the planner indicates all its registered workers to flush.
This change simplifies the logic on the worker side, which only needs to flush locally when indicated to do so.