Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Semantic Versioning #775

Merged
merged 12 commits into from
Jul 20, 2023
Merged

Use Semantic Versioning #775

merged 12 commits into from
Jul 20, 2023

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Jul 20, 2023

In this PR I move Faasm and its tightly coupled dependencies (faasm/faabric#334, faasm/cpp#120, and faasm/python#30) to use semantic versioning, or SemVer.

Admittedly, Faasm doesn't expose a stable API, and it will never reach a stable version (i.e. >=1.0.0 according to SemVer). Still, SemVer provides some rationale re. when to tag a new version. Whereas until now we had no rationale at all (only whenever we wanted a new container image).

In summary, with SemVer:

  • We tag a new minor version (inv git.bump --minor) any time we introduce a new feature.
  • We tag a new patch version (inv git.bump --patch) any time we fix a bug.

We are still a bit selective wrt to what is a feature and what is a bug, and it will still be ultimately arbitrary. But at least it provides a bit more order.

In addition, I also move the tasks to bump tracked dependencies to inv git.bump-dep [--faabric,cpp,python,faasmctl], and bump the faasmctl version to fix the Azure integration tests.

@csegarragonz csegarragonz marked this pull request as ready for review July 20, 2023 14:00
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #775 (f74422b) into main (4aa6888) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f74422b differs from pull request most recent head c14a964. Consider uploading reports for the commit c14a964 to get more accurate results

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   67.43%   67.40%   -0.03%     
==========================================
  Files          69       69              
  Lines        7729     7729              
==========================================
- Hits         5212     5210       -2     
- Misses       2517     2519       +2     

see 1 file with indirect coverage changes

@csegarragonz csegarragonz merged commit 2af450e into main Jul 20, 2023
17 checks passed
@csegarragonz csegarragonz deleted the bump-faasmctl branch July 20, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant