Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure Integration Tests #781

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix Azure Integration Tests #781

merged 2 commits into from
Jul 28, 2023

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Jul 28, 2023

With #779 we added a task to purge old ACR images. We then deleted the images that the faasmctl version used in Faasm was pinned to.

The fix has two parts:

  • Bump faasmctl to a new enough version that supports setting the Faasm version
  • Set the Faasm version as an env. variable for the Azure integration tests

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #781 (02b8130) into main (27e2a06) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   67.43%   67.47%   +0.03%     
==========================================
  Files          69       69              
  Lines        7760     7760              
==========================================
+ Hits         5233     5236       +3     
+ Misses       2527     2524       -3     

see 1 file with indirect coverage changes

@csegarragonz csegarragonz merged commit a4b9a33 into main Jul 28, 2023
22 checks passed
@csegarragonz csegarragonz deleted the fix-gha branch July 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant