Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faasmctl #785

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Use faasmctl #785

merged 3 commits into from
Aug 2, 2023

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Aug 2, 2023

This PR officially ditches the old ./bin/cli.sh approach to starting development cluster and switches to faasmctl.

faasmctl is a command line tool used to interact with a running Faasm cluster. It has been used as part of GHA for a while, and now I update the docs to include it.

By using faasmctl we move all the logic of interacting with a running Faasm cluster from ./faasmcli/ to a different repository. This also means that any interaction with the HTTP endpoints should be done either through the faasmctl script, or the API that it exposes. Note that faasmctl is installed with pip as part of source ./bin/workon.sh.

This means, that now before doing anything in Faasm, we always need to activate the virtual environment:

source ./bin/workon.sh
faasmctl --version

avoiding the confusion about what is mounted and what is not.

In a subsequent PR I will remove all the tasks in ./faasmcli that are now obsolete, and leave the rest (generally true development tasks) in the usual ./tasks.

Closes #636
Closes #722

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #785 (2becdf1) into main (733cf4d) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   67.48%   67.44%   -0.04%     
==========================================
  Files          69       69              
  Lines        7762     7762              
==========================================
- Hits         5238     5235       -3     
- Misses       2524     2527       +3     

see 1 file with indirect coverage changes

@csegarragonz csegarragonz self-assigned this Aug 2, 2023
@csegarragonz csegarragonz merged commit df850ff into main Aug 2, 2023
19 checks passed
@csegarragonz csegarragonz deleted the use-faasmctl branch August 2, 2023 17:55
@csegarragonz csegarragonz mentioned this pull request Aug 3, 2023
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with FAASM_BUILD_DIR
1 participant