Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(faabric): bump planner to detect more migration opportunities #827

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Feb 1, 2024

See faasm/faabric#369 for more details.

After bumping to faasmctl==0.28.0 we can now test the PR locally as follows:

# Make sure each worker has 4 slots
faasmctl deploy.compose --workers=3

faasmctl upload.wasm lammps main <path_to_wasm>

# Shell 1: monitoring the planner
faasmctl monitor.planner

# Shell 2:  invoke one app split in two hosts
faasmctl invoke lammps migration --cmdline '-in faasm://lammps-data/in.controller.wall' --mpi-world-size 4 --input-data '1 2' --host-dist "0:2,1:2"

# Shell 3: invoke the same app
faasmctl invoke lammps migration --cmdline '-in faasm://lammps-data/in.controller.wall' --mpi-world-size 4 --input-data '1 2' --host-dist "0:2,1:2"

you should see both apps being scheduled in the same two hosts. After a while, the first one will be migrated to the (empty) third host, and the second one will be concentrated.

Annoyingly, this situation requires at least three worker nodes, so we cannot really test it in the distributed tests.
I am resurrecting the e2e tests PR to try and test it there.

@csegarragonz csegarragonz marked this pull request as ready for review February 2, 2024 16:51
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7346dc9) 67.55% compared to head (603274b) 67.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   67.55%   67.54%   -0.02%     
==========================================
  Files          71       71              
  Lines        7884     7884              
==========================================
- Hits         5326     5325       -1     
- Misses       2558     2559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csegarragonz csegarragonz merged commit 514de62 into main Feb 6, 2024
20 checks passed
@csegarragonz csegarragonz deleted the more-migrations branch February 6, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant