Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache headers not being set on AWS #185

Closed
thejuan opened this issue May 21, 2020 · 5 comments · Fixed by #186
Closed

Cache headers not being set on AWS #185

thejuan opened this issue May 21, 2020 · 5 comments · Fixed by #186

Comments

@thejuan
Copy link
Contributor

thejuan commented May 21, 2020

Not sure if I set it up badly, but I'm not getting cache headers on my asset responses

content-encoding: gzip
content-type: application/javascript; charset=utf-8
date: Thu, 21 May 2020 01:20:13 GMT
last-modified: Thu, 21 May 2020 00:17:17 GMT
server: AmazonS3
status: 200
vary: Accept-Encoding
via: 1.1 cc3ab544aae38adfcc35bb790a813e46.cloudfront.net (CloudFront)
x-amz-cf-id: T3zX8wNNw9_T3awgXh7Q2kplZ9bhlhJqjKJIUOwQJpt0Ms8-1E1Ong==
x-amz-cf-pop: SYD4-C2
x-cache: Miss from cloudfront

Can view here https://register.hatch.exchange/?homecompany=domain

@evanderkoogh evanderkoogh linked a pull request May 21, 2020 that will close this issue
@evanderkoogh
Copy link
Collaborator

Looks like the header do not actually get set. I have created a PR to add those to the S3 objects in the deployer in #186

@thejuan
Copy link
Contributor Author

thejuan commented May 21, 2020

Does CF pass through origin headers? Should this be set on the CloudFormation CF behaviour for assets path?

Edit
Most, no. :)

@geelen
Copy link
Contributor

geelen commented May 21, 2020

Pushed a new version of all packages, 1.0.0-rc.2.alpha.0, with this merged in. Can be accessed under the next tag, so pop that in your package.json manually or use npx fab@next init --version=next if you want to configure a new repo with the prerelease stuff.

@geelen
Copy link
Contributor

geelen commented May 21, 2020

Should hopefully get a proper RC2 out tomorrow btw

@thejuan
Copy link
Contributor Author

thejuan commented May 21, 2020

Thanks, still blocked by #182 so can’t take this in yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants