Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The namespace of CSVExtractor seems wrong #2

Closed
guillermowelch opened this issue Jul 25, 2019 · 3 comments · Fixed by #3
Closed

The namespace of CSVExtractor seems wrong #2

guillermowelch opened this issue Jul 25, 2019 · 3 comments · Fixed by #3
Labels

Comments

@guillermowelch
Copy link

The namespace of YaEtl/src/Extractors/File/CSVExtractor.php is:

namespace fab2s\YaEtl\Loaders\File;

On the other hand, YaEtl/src/Extractors/File/LineExtractor.php is:

namespace fab2s\YaEtl\Extractors\File;

Seems the first file is in a wrong namespace.

@fab2s
Copy link
Owner

fab2s commented Jul 25, 2019

You are right, composer and IDE teamed up to hide this one (tests are working).

I'm concerned with BC for this one, have to think.

Ty for reporting.

@guillermowelch
Copy link
Author

Composer's autoloader makes it work (unless you use the use sentence with the wrong namespace), so no tests should fail with this one.

@fab2s
Copy link
Owner

fab2s commented Jul 25, 2019

It's not so PSR4 as a namespace, I guess composer could have been a bit more dramatic about it.

@fab2s fab2s added the design label Jul 25, 2019
fab2s referenced this issue Jul 25, 2019
@fab2s fab2s mentioned this issue Jul 25, 2019
fab2s added a commit that referenced this issue Jul 25, 2019
@fab2s fab2s closed this as completed in #3 Jul 25, 2019
fab2s added a commit that referenced this issue Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants