Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special attributes with business logic (eg. "password") #48

Open
leogr opened this issue Jan 10, 2018 · 6 comments
Open

Special attributes with business logic (eg. "password") #48

leogr opened this issue Jan 10, 2018 · 6 comments

Comments

@leogr
Copy link
Collaborator

leogr commented Jan 10, 2018

It's needed to implement a way to apply the internal service provider logic to some attributes.
For example, password must be hashed prior to being stored.

Middleware pattern could be useful to accomplish that.

@leogr leogr mentioned this issue Jan 10, 2018
5 tasks
leodido pushed a commit that referenced this issue Feb 13, 2018
@leogr
Copy link
Collaborator Author

leogr commented Feb 21, 2018

Has been this feature fully implemented?

@alelb
Copy link
Collaborator

alelb commented Feb 22, 2018

Hi @leogr, have you had a look to f9b0edb?
There is no support for compare more than one password in a search request.

@leogr
Copy link
Collaborator Author

leogr commented Feb 22, 2018

It's dirty... btw is it working?

leodido pushed a commit that referenced this issue Feb 22, 2018
@leodido
Copy link
Collaborator

leodido commented Feb 26, 2018

@alelb news pls?

@alelb
Copy link
Collaborator

alelb commented Feb 26, 2018

@leogr @leodido
It's dirty and rough but It's working . It's missing the ability to compare more than one password per query.
It's missing tests too.

@leogr
Copy link
Collaborator Author

leogr commented Feb 26, 2018

Assuming a dirty solution, I propose to implement integration test only (short-term), so when we change the implementation we can test the correct behaviour.
@leodido Do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants