Refactoring #28
Merged
Refactoring #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alelb
approved these changes
Nov 29, 2017
leogr
force-pushed
the
feature/refactoring
branch
from
7ee2abe
to
7e4c83d
Compare
leodido
requested changes
Nov 29, 2017
schemas/core/resource.go
Outdated
|
|
||
| // ResourceTyper is the interface implemented by types that can hold Common resource attribute and are can return it ResourceType | ||
| type ResourceTyper interface { | ||
| ResourceType() *ResourceType | ||
| GetCommon() *Common |
There was a problem hiding this comment.
Why not simply Common() ?
Do you mean if I refactor ?
There was a problem hiding this comment.
We cannot use Common() because its name will collide with Common struct member.
For the same reason we have GetSchema() instead of Schema()
:(
There was a problem hiding this comment.
You're right ... Hmmm :\
I propose to rename Common struct field into CommonAttributes or something similar.
And then rename GetCommon() to simply Common().
There was a problem hiding this comment.
I agree, so I'm going to fix right now.
leodido
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #9 and #10.
Also, it makes the naming convention more clear and closer to Golang one.
Eg, now you can use
datatype.New()instead ofcore.NewDataType()Notice that, I've not promoted
schemas/attributeto package because IMHO it's not needed.Maybe, I will add just few commits trying to remove a bit of code dup (eg.
AttrNameExpr).However, review it ASAP because it's blocking, please.