Server #46
Merged
Server #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
force-pushed
the
feature/server
branch
from
1e0c30d
to
83f24fa
Compare
leodido
force-pushed
the
feature/server
branch
from
589d95f
to
0e4f6ff
Compare
leogr
reviewed
Jan 24, 2018
| @@ -81,3 +81,43 @@ func TestResourceTypeRepository(t *testing.T) { | |||
|
|
|||
| // (todo): test lock | |||
| } | |||
|
|
|||
| // (todo): test list | |||
There was a problem hiding this comment.
It was tested below, isn't it?
There was a problem hiding this comment.
Yeah, I'll remove this comment.
leogr
approved these changes
Jan 24, 2018
server/server.go
Outdated
| switch authenticationType { | ||
| case strings.ToLower(HTTPBasic.String()): | ||
| return gin.BasicAuth(gin.Accounts{ | ||
| "admin": "admin", |
There was a problem hiding this comment.
Pls, fetch credentials from config or add a (todo) just to do not forget
There was a problem hiding this comment.
Adding a TODO. Thanks.
GET /v2/Schemas/<id> GET /v2/ResourceTypes/<id> GET /v2/Schemas (missing check, implementation not complete) GET /v2/ResourceTypes (missing check, implementation not complete)
3 tasks
|
We are almost there guys ... cc @fabbricadigitale/openinnovation |
alelb
force-pushed
the
feature/server
branch
from
3dc1889
to
236cc33
Compare
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
alelb
force-pushed
the
feature/server
branch
from
236cc33
to
2264275
Compare
Co-authored-by: Alessandro La Bella <sandrone.lb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.