(AjaxQueue): fix the Reconnect link not showing after server error 500 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't happen... but unless showing the "Reconnect" link (#uiFcAjaxError div in flashcard review page), then the AjaxQueue is frozen -- and the review will never recover if the server had a hiccup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't happen... but the server does throw a HTTP 500 sometimes if the database is too busy or for whatever reason (shared server).
In those cases a mishandling of the error caused the "Oops! Error XYZ (Reconnect link)" dialog to not show up... therefore user is not able to proceed with the review if the server had a hiccup. bad bug! 馃サ
This happens because server can issue a HTTP 500 with
RTK-Errorheader with more information. However if the error is not caused by our exception the header doesn't exist and sErrorMessage isundefined, notnull.