Refactor/232 add foolproof checks for srs ratings and sql updates #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check also prevents an "out of memory" error due to unexpected loop logic following. This will still prevent accessing the SRS chart; which is probably better if a flashcard upate somehow messed the leitnerbox value -- to prevent further reviews from happening. But this will output errors in error_log(). Part of #232 resolution
Prevent updating flashcard in the DB if a refactoring / bug causes leitnerbox to be NULL or zero for whatever reason.
Closes #232 Prevent bugs that may happen due to refactoring, or maybe a new client that sends incorrect request.
fabd
deleted the
refactor/232-add-foolproof-checks-for-srs-ratings-and-sql-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.