Feature/issue 251 improve learned list #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why this was ever conditional to the API (KanjiRyokucha)... The list is no longer cleared at end of SRS review. Learned kanji remain Indefinitely unless user explicitly clears the list, or during review. If kanji is forgotten, it needs to be re-learned, so clear flag. If kanji is remembered, it is no longer in the Restudy list, clear flag.
- replace lots of Bootstrap buttons to new `.ko-Btn` classes - remove "button with icon" helper (simplify)
Old site has 14px, but our body font size now defaults to 16.
Show the "Learned 0 of X" pane after user clicks "Begin Restudy". If user moves to another kanji, then the pane goes back to "Restudy" (red) - until there is at least one kanji in the learned list, in which case the "Learned" pane is shown.
Attempt to improve the flow, if the user doesn't use "Continue Restudy" but instead wants to pick from the list. The "Study" link will return the user to the Restudy List, after they select "Add to learned list" on the Study page.
…arned" Avoid confusing UX where two buttons with different styles end up doing the same thing when in this state (user now should pick "Review Learned Kanji")
... attempt to fix error when running vue-tsc, stopped working for whatever reason. Still doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
This feature includes substantial refactors I didn't manage to put in separate branches:
.ko-Btn.ko-Btn--success.ko-Btn--largeetc ) which will work better with tailwind, and is compatible with using element-plus buttons should we need them/uxwhich demo all the button styles!