Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for public release #27

Closed
vincentbrison opened this issue Apr 20, 2020 · 7 comments · Fixed by #43
Closed

Update documentation for public release #27

vincentbrison opened this issue Apr 20, 2020 · 7 comments · Fixed by #43
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@vincentbrison
Copy link
Contributor

To be able to properly put the project in open source, we should work on the documentation:

@vincentbrison vincentbrison added the documentation Improvements or additions to documentation label Apr 20, 2020
@vincentbrison vincentbrison added this to the v1 milestone Apr 20, 2020
@sjcqs
Copy link
Contributor

sjcqs commented Apr 21, 2020

Badge for snapshot release:

Build test and deploy snapshot images

![Build test and deploy snapshot images](https://github.com/faberNovel/docker-android/workflows/Build%20test%20and%20deploy%20snapshot%20images/badge.svg)

@vincentbrison
Copy link
Contributor Author

vincentbrison commented Apr 21, 2020

About image documentation:
We should add a script which is able to be run by an image to describe the image. For instance, it could print:

  • All packages installed with their version, from apt
  • rbenv version, default ruby env, all gems installed and their version from default ruby env
  • java version
  • Android API version, Android NDK version

When a release is published, GitHub Action would generate a Changelog.md using standard tools as https://github.com/github-changelog-generator/github-changelog-generator, and would also commit images descriptions using script described ahead.

Those files could also be attached to GitHub Release to be able to have a quick look at whats available.

In a second time we could take a look at automate creation of draft GitHub release, which would trigger all tasks described above, without commit the files, to be sure everything is fine, when a branch like releases/v* is open. Then we would only allow manual publish using GitHub interface from those draft release.

What do you think about that @sjcqs ?

@sjcqs
Copy link
Contributor

sjcqs commented Apr 21, 2020 via email

@vincentbrison
Copy link
Contributor Author

Seems good to me, will look into it.

@vincentbrison
Copy link
Contributor Author

Depend on #29

@vincentbrison
Copy link
Contributor Author

Still need to create an action to:

  • on release/** PR merged
  • deploy images
  • create release

cd_release.yml should be updated according this

@vincentbrison
Copy link
Contributor Author

All above is done. Still need to add sample on GitHub Action integration, and some cleanup in readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants