Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Action testing #79

Closed
vincentbrison opened this issue Jul 1, 2020 · 4 comments · Fixed by #82
Closed

Improve Action testing #79

vincentbrison opened this issue Jul 1, 2020 · 4 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@vincentbrison
Copy link
Contributor

Currently the action is tested using the same tests as the image (check ci_action.yml).
This leads to issues as the action is relying on a pre compiled image pulled of DockerHub, and thus, any change in the image reflected in the tests will break in the action.
We could create a specific test suite for the action, as we do not need to test the image itself, but whether if the action is working or not (ability to pull image, to run a basic fastlane command, correctness in inputs reading).

@vincentbrison vincentbrison added the enhancement New feature or request label Jul 1, 2020
@sjcqs
Copy link
Contributor

sjcqs commented Jul 2, 2020

Instead of launching them in every PR they could be run either/both:

  • When making a release (against snapshot images)
  • Nightly (against snapshot images)

@vincentbrison
Copy link
Contributor Author

Conceptually, it looks weird to run tests coming from the docker image for the action. It is like we are testing two times the same thing, like if we did not have confidence into our tests for the docker image.
@sjcqs do you still think we should run the same test suite, but only on release or nightly? I think it could be overwhelming, as when doing a release, everything should already be tested. You do not want to fix something broke, when doing a release.

@sjcqs
Copy link
Contributor

sjcqs commented Jul 8, 2020

Since the Github Action is really simple and just wraps our images, we could get rid of the tests on it, yes 🤷.

@vincentbrison
Copy link
Contributor Author

Ok, I will look into building a specific test suite for the action then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants