You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the action is tested using the same tests as the image (check ci_action.yml).
This leads to issues as the action is relying on a pre compiled image pulled of DockerHub, and thus, any change in the image reflected in the tests will break in the action.
We could create a specific test suite for the action, as we do not need to test the image itself, but whether if the action is working or not (ability to pull image, to run a basic fastlane command, correctness in inputs reading).
The text was updated successfully, but these errors were encountered:
Conceptually, it looks weird to run tests coming from the docker image for the action. It is like we are testing two times the same thing, like if we did not have confidence into our tests for the docker image. @sjcqs do you still think we should run the same test suite, but only on release or nightly? I think it could be overwhelming, as when doing a release, everything should already be tested. You do not want to fix something broke, when doing a release.
Currently the action is tested using the same tests as the image (check ci_action.yml).
This leads to issues as the action is relying on a pre compiled image pulled of DockerHub, and thus, any change in the image reflected in the tests will break in the action.
We could create a specific test suite for the action, as we do not need to test the image itself, but whether if the action is working or not (ability to pull image, to run a basic fastlane command, correctness in inputs reading).
The text was updated successfully, but these errors were encountered: