Add setup-ruby support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flolom
force-pushed
the
feature/add-setup-ruby-support
branch
from
9bebbb7
to
8dd9553
Compare
ferrandp
approved these changes
Apr 28, 2022
flolom
force-pushed
the
feature/add-setup-ruby-support
branch
from
8dd9553
to
0e3665d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by the documentation of actions/cache, it is strongly recommended to use the setup-ruby action to have a working cache for ruby/bundler.
This is something that I noticed on projects that uses ruby (and fastlane) : most of the time the cache is not hit and bundler is downloading and installing the dependencies again and again and again.
Becausesetup-rubyalso downloads and install a precompiled ruby runtime, I have removed the ruby runtime from the docker image, because it will be unused. This is breaking change and can be discussed : maybe we should keep it for developers that will not use thesetup-rubyaction ?EDIT : Let's keep the ruby runtime for now (retrocompatibility issues)
From experience
setup-rubyis pretty fast : it takes <10sec to download and install the ruby runtime and restore the cache