Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle cache readme / Fix build tools #106

Merged
merged 3 commits into from
May 5, 2022

Conversation

flolom
Copy link
Member

@flolom flolom commented Apr 28, 2022

Update gradle cache actions to the most recent recommandations https://github.com/actions/cache/blob/main/examples.md#java---gradle

@flolom flolom requested a review from ferrandp April 28, 2022 09:45
"build_tools": "32.0.0"
"build_tools": "30.0.3"
Copy link
Contributor

@ferrandp ferrandp Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il faudrait pas plutôt les builds 31.0.0 plutôt que 30.0.3 pour l'API 31 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De ce que j'ai lu les build-tools 31 sont corrompus https://stackoverflow.com/questions/68387270/android-studio-error-installed-build-tools-revision-31-0-0-is-corrupted

Et sur un projet en compileSdk 31 (qui ne précise pas version particulière de build-tools), ce sont les build-tools 30.0.3 qui vont être fetch.
Mais oui c'est pas évident, je vais rajouter un com'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ah: !

Ok, dans ce cas je pense que ce sera bien avec un commentaire :)

@flolom flolom force-pushed the feature/gradle-cache-readme branch from a823123 to f53d359 Compare May 5, 2022 13:19
@flolom flolom merged commit 2f2c63c into develop May 5, 2022
@flolom flolom deleted the feature/gradle-cache-readme branch May 5, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants