Test Firebase Test Lab Integration #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjcqs
commented
Apr 21, 2020
sjcqs
commented
- Add a daily runner running both tests and firebase test lab integration
- Run firebase test lab integration test when releasing
added 10 commits
April 20, 2020 16:06
Use the same version as the other tests
sjcqs
force-pushed
the
feature/feature/firebase_test_lab_app
branch
from
95a5d5e
to
e75f7c0
Compare
sjcqs
force-pushed
the
feature/feature/firebase_test_lab_app
branch
from
e75f7c0
to
c14a7c2
Compare
vincentbrison
suggested changes
Apr 21, 2020
ci_cd.sh
Outdated
| @@ -22,19 +22,22 @@ function usage { | |||
| echo " --ndk_version <version> Install a specific Android NDK version from \`sdkmanager --list\`" | |||
| echo " --build Build image" | |||
| echo " --test Test image" | |||
| echo " --test-lab Test instrumented tests on Firebase Test Lab" | |||
There was a problem hiding this comment.
Should not we pick a name a bit more different from test parameter as it might be confusing? test will run all unit or local test. Maybe we can use the same semantic as https://developer.android.com/reference/android/test/suitebuilder/annotation/LargeTest. So we would have test and large-test options. We could evolve these parameters documentation this way:
test: Test image with local tests local testslarge-test: Test image with remote services (Firebase Test Lab)
What do you think about that?
vincentbrison
suggested changes
Apr 21, 2020
ci_cd.sh
Outdated
| @@ -22,22 +22,22 @@ function usage { | |||
| echo " --ndk_version <version> Install a specific Android NDK version from \`sdkmanager --list\`" | |||
| echo " --build Build image" | |||
| echo " --test Test image" | |||
| echo " --test-lab Test instrumented tests on Firebase Test Lab" | |||
| echo " --large-test Test instrumented tests on Firebase Test Lab" | |||
There was a problem hiding this comment.
You updated value name, but not the description, is this intended? See #28 (comment). Also the doc should be align l25
vincentbrison
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.