Feature/image description #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentbrison
commented
Apr 21, 2020
ci_cd.sh
Outdated
| @@ -23,6 +23,7 @@ function usage { | |||
| echo " --build Build image" | |||
| echo " --test Test image" | |||
| echo " --deploy Deploy image" | |||
| echo " --desc Generate a desc.md file describing the builded image" | |||
There was a problem hiding this comment.
Doc is wrong. Should be txt, and add info on how to gather the generated file.
vincentbrison
force-pushed
the
feature/image_description
branch
from
9c11bf7
to
4f4a5cf
Compare
sjcqs
reviewed
Apr 21, 2020
desc/desc.sh
Outdated
| rbenv -v | ||
| ruby -v | ||
| gem list | ||
| echo '\n' |
There was a problem hiding this comment.
echo will print an empty line
sjcqs
reviewed
Apr 21, 2020
desc/desc.sh
Outdated
|
|
||
| echo "gcloud env:" | ||
| gcloud --version | ||
| echo '\n' |
sjcqs
reviewed
Apr 21, 2020
desc/desc.sh
Outdated
Comment on lines
7
to
15
| rbenv -v | ||
| ruby -v | ||
| gem list |
There was a problem hiding this comment.
Add sub categories: rbenv, ruby and gems
sjcqs
suggested changes
Apr 21, 2020
desc/desc.sh
Outdated
| rbenv -v | ||
| ruby -v | ||
| gem list | ||
| echo '\n' |
There was a problem hiding this comment.
echo will print an empty line
sjcqs
approved these changes
Apr 21, 2020
vincentbrison
force-pushed
the
feature/image_description
branch
from
9efe4e9
to
bb276c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now generating raw txt output. In next version we could parse output to generate proper md file. Fix #29