Feature/update release flow #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjcqs
suggested changes
May 12, 2020
| - name: Upload image description | ||
| uses: actions/upload-artifact@v2-preview | ||
| with: | ||
| path: desc/output/*.txt |
There was a problem hiding this comment.
You changed the extension to .md
There was a problem hiding this comment.
Yes, that is the intention of c0bb788. As those files are in MD format, and are now commited on release, this will allow to display those files through github markdown renderer.
There was a problem hiding this comment.
The generated files extension was changed but not the files uploaded.
Are there files which match desc/output/*.txt to upload ? If not, this should be replaced with desc/output/*.md or removed.
There was a problem hiding this comment.
I forgot to remove this step. Now image descriptions will also be versioned so no need to attach them with release artifact.
There was a problem hiding this comment.
Should be good
sjcqs
approved these changes
May 13, 2020
vincentbrison
force-pushed
the
feature/update_release_flow
branch
from
5cfd55c
to
07418ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51