Install jenv to handle JDK versions #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjcqs
suggested changes
Sep 15, 2020
README.md
Outdated
Comment on lines
36
to
38
| Images support multiple JDK, using [Jenv](https://www.jenv.be/). | ||
| By default JDK 11 is used, but JDK 8 is also supported (use `jenv global 1.8`). | ||
| To choose a JDK, make sure the script executes on a bash shell, then use Jenv with the desired version: |
There was a problem hiding this comment.
Suggested change
| Images support multiple JDK, using [Jenv](https://www.jenv.be/). | |
| By default JDK 11 is used, but JDK 8 is also supported (use `jenv global 1.8`). | |
| To choose a JDK, make sure the script executes on a bash shell, then use Jenv with the desired version: | |
| Images support multiple JDK using [Jenv](https://www.jenv.be/). | |
| The default JDK is JDK 11 is used, but JDK 8 is also supported (use `jenv global 1.8`). | |
| To choose a JDK, make sure the script executes on a bash shell, then use Jenv to set the desired version: |
Dockerfile
Outdated
| RUN jenv add ${JDK_ROOT}/java-11-openjdk-amd64 | ||
| RUN echo 'export PATH="$JENV_ROOT/bin:$PATH"' >> ~/.bashrc | ||
| RUN echo 'eval "$(jenv init -)"' >> ~/.bashrc | ||
| RUN source ~/.bashrc |
ferrandp
force-pushed
the
feature/jenv
branch
from
0733dfb
to
8eb8c9e
Compare
sjcqs
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #93
Add support for Jenv and JDK 8