feat: Copy existing task definition tags #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabfuel
reviewed
Aug 7, 2020
nitrocode
changed the title
nitrocode
changed the title
|
Hi @fabfuel , would you mind checking this PR again when you're free? I believe I fixed all the issues with it. |
nitrocode
changed the title
fabfuel
approved these changes
Sep 6, 2020
There was a problem hiding this comment.
Looks good, thanks a lot @nitrocode !
I will merge and release the next days.
Best
Fabian
|
Thanks @fabfuel. Looking forward to it! 😄 |
|
@fabfuel thanks for merging. Will there be a new release? |
|
Hi @nitrocode! I just created the release and pushed it to PyPI. Sorry for the delay - very busy weeks... 😅 Thanks again for your contribution - all the best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tags in the describe_task_definition should give us the tags for registering new task definitions
Closes #130