Change emoji regex to support older JS runtimes #599

fabian-hiller · May 24, 2024 · 8819268 · 8819268
1 parent 51d1e98
commit 8819268
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 18 deletions.
diff --git a/library/src/actions/emoji/emoji.test.ts b/library/src/actions/emoji/emoji.test.ts
@@ -112,26 +112,30 @@ describe('emoji', () => {
       ]);
     });
 
-    test('for numbers', () => {
-      expectActionIssue(action, baseIssue, [
-        '0',
-        '1',
-        '2',
-        '3',
-        '4',
-        '5',
-        '6',
-        '7',
-        '8',
-        '9',
-        '0123456789',
-      ]);
-    });
+    // TODO: This test needs to be enabled after upgrading the emoji regex.
+    // See the comment in `regex.ts` for more details.
+    // test('for numbers', () => {
+    //   expectActionIssue(action, baseIssue, [
+    //     '0',
+    //     '1',
+    //     '2',
+    //     '3',
+    //     '4',
+    //     '5',
+    //     '6',
+    //     '7',
+    //     '8',
+    //     '9',
+    //     '0123456789',
+    //   ]);
+    // });
 
     test('for special chars', () => {
       expectActionIssue(action, baseIssue, [
-        '#',
-        '*',
+        // TODO: These chars needs to be enabled after upgrading the emoji regex.
+        // See the comment in `regex.ts` for more details.
+        // '#',
+        // '*',
         '!',
         '@',
         '$',

diff --git a/library/src/regex.ts b/library/src/regex.ts
@@ -22,7 +22,11 @@ export const EMAIL_REGEX =
 /**
  * Emoji regex.
  */
-export const EMOJI_REGEX = /^\p{RGI_Emoji}+$/v;
+export const EMOJI_REGEX = /^[\p{Extended_Pictographic}\p{Emoji_Component}]+$/u;
+
+// This emoji regex is not supported in Node.js v18 and older browsers.
+// Therefore, we are postponing the switch to this regex to a later date.
+// export const EMOJI_REGEX = /^\p{RGI_Emoji}+$/v;
 
 /**
  * [Hexadecimal](https://en.wikipedia.org/wiki/Hexadecimal) regex.