Cross field validation?

[romanslonov]

Hello, thank you for an amazing library!

I started using it in my project but run into a problem with cross field validation. For example, I have an array of objects and one property of the object should be unique.

This is my try to implement this, but problem is that the error message for custom validation will be collected for rules instead of specific source port's input.

rules: array(LBRuleSchema, [
  minLength(1, 'min 1 rule should be defined'),
  (input, info) => {
    if (!isUnique(input.map((item) => item.sourcePort))) {
      throw new ValiError([
        {
          validation: 'custom',
          origin: 'value',
          message: `Source port should be unique`,
          input,
          ...info,
        },
      ]);
    }

    return input;
  },
]),

Another example, I have an object and validation of certificate depends on protocol.value value. I would like to do this check in certificate, but cannot get context. Or I just didn't find a way?

const LBRuleSchema = object(
  {
    certificate: optional(CertificateSchema),
    protocol: object({
      value: enumType(['http', 'https', 'http2'] as const),
      label: string(),
    }),
    sourcePort: number('Must be >= 1', [
      minValue(1, 'Min number of port is 1'),
      maxValue(65534, 'Max number of port is 65534'),
    ]),
    targetPort: number('Must be >= 1'', [
      minValue(1, 'Min number of port is 1'),
      maxValue(65534, 'Max number of port is 65534'),
    ]),
  },
  [
    (input, info) => {
      if (
        (input.protocol.value === 'https' || input.protocol.value === 'http2') &&
        !input.certificate
      ) {
        throw new ValiError([
          {
            validation: 'custom',
            origin: 'value',
            message: `Certificate is required for ${input.protocol.value.toUpperCase()}`,
            input,
            ...info,
          },
        ]);
      }

      return input;
    },
  ],
);

Thanks.

[fabian-hiller]

Hey, thanks for creating this discussion. Please read through the following two issues and let me know if your questions are answered. Otherwise, I can try to address your specific use case.

• Conditionally requiring object fields #5
• How to control 2 fields equal or not #76

[fabian-hiller]

Currently, it is necessary to recreate the entire path to the problem so that the error message is assigned correctly. You have to do the same thing as Zod, but with a little more effort. I plan to improve this in the next few weeks.

import {
  Issue,
  Issues,
  ValiError,
  any,
  array,
  minLength,
  object,
  optional,
  string,
} from "valibot";

const CertificateSchema = any();

const FormSchema = object({
  rules: array(
    object(
      {
        protocol: string(),
        sourcePort: string([minLength(1, "Source port is required")]),
        certificate: optional(CertificateSchema),
      },
      [
        (input) => {
          if (input.protocol === "https" && !input.certificate) {
            throw new ValiError([
              {
                reason: "any",
                validation: "custom",
                origin: "value",
                message: "Certificate is required for HTTPS",
                input: input.certificate,
                path: [
                  {
                    schema: "object",
                    input: input,
                    key: "certificate",
                    value: input.certificate,
                  },
                ],
              },
            ]);
          }
          return input;
        },
      ]
    ),
    [
      (items) => {
        const issues: Issue[] = [];

        items.forEach((item, i) => {
          const dup = items.find(
            (r, j) => r.sourcePort === item.sourcePort && i !== j
          );

          if (!!dup) {
            issues.push({
              reason: "string",
              validation: "custom",
              origin: "value",
              message: "Duplicate source port",
              input: item.sourcePort,
              path: [
                {
                  schema: "array",
                  input: items,
                  key: i,
                  value: item,
                },
                {
                  schema: "object",
                  input: item,
                  key: "sourcePort",
                  value: item.sourcePort,
                },
              ],
            });
          }
        });

        if (issues.length) {
          throw new ValiError(issues as Issues);
        }

        return items;
      },
    ]
  ),
});

[romanslonov]

@fabian-hiller Sorry for the delay. Just try your code, it collects errors in global object (whole form) but not for specific field (item.sourcePort).

[fabian-hiller]

Can you give me more details? And in general, also for others, the code from above doesn't work anymore with the latest version.

[romanslonov]

It doesn't generate error message for specific field. Maybe, because your code generates paths like 1.sourcePort but should be rules[1].sourcePort.

[fabian-hiller]

Can you send me the output of the error message?