-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename C and CO to U and UO #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is consistent and improves the repo. I used the review as an opportunity to reflect some blunt thoughts about the already existing ideas in the repo which are unrelated to the change.
- *Burstable CPU performance* - The workload has a baseline compute | ||
performance but is permitted to burst beyond this baseline, if | ||
excess compute is available | ||
- *Cache backed RAM* - VM RAM is cached based in order to provide memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- will leverage file system cache and be fast, but as soon as node memory arises, the memory of the VMs will be pushed out of RAM, because the cache will be dropped.
The close distance to CX but the fact that C and CO are "workload agnostic" was confusing. Thus rename those types which are agnostic to use a different prefix. The prefix is now U, a hint at the expansion "Universal". Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Was messing up memory ratios because sorting was broken Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Merging for now. |
The close distance to CX but the fact that C and CO are "workload agnostic" was confusing.
Thus rename those types which are agnostic to use a different prefix. The prefix is now U, a hint at the expansion "Universal".