IDDQD: fix reviving if god mode was already enabled #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiangreffrath
approved these changes
Oct 27, 2023
|
IIRC, aside from telefragging, player can die in god mode in Terry WADs that became a meme in the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the player enables god mode through the IDDQD cheat, dies, and then enters the cheat again to respawn, they'll respawn in a "zombie" state (which I assume is not intentional), similar to this, because health is not reset from 0. This is unlikely to happen because the player shouldn't die in god mode, but it's possible in some cases, like telefragging.
This PR forces the player's health to that of god mode when respawning through IDDQD, regardless of whether god mode is being enabled or disabled, which doesn't change anything for the former case, and fixes respawning for the latter.