Small datadirs improvement #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dir = M_StringJoin(result, "darkwar", PATH_SEP_STR, NULL); | ||
| #else | ||
| dir = M_StringJoin(result, "huntbgin", PATH_SEP_STR, NULL); |
There was a problem hiding this comment.
Do we already know the name of the WAD at this point and can use this, instead of hard-coding it based on compile time options?
There was a problem hiding this comment.
The WAD names themselves are still hardcoded based on the same compile time option, so I don't know if it matters here. I think it should be changed if we ever do a bigger update to how the game/mod mounting & loading works, but I don't know if now's the time.
fabiangreffrath
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saving configuration files inconsistently between shareware and registered, this PR ensures that they are saved into the same Taradino folder, in a subfolder for the name of the WAD. For registered, this is "darkwar" and for shareware this is "huntbgin". This can be expanded later for any other game WADs that could be loaded (i.e. huntbgn2.wad, or Extreme ROTT).