Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add obituaries from ZDoom (optional) #1092

Closed
fabiangreffrath opened this issue Jun 5, 2023 · 12 comments · Fixed by #1198
Closed

add obituaries from ZDoom (optional) #1092

fabiangreffrath opened this issue Jun 5, 2023 · 12 comments · Fixed by #1198

Comments

@fabiangreffrath
Copy link
Owner

fabiangreffrath commented Jun 5, 2023

Now that we are able to selectively enable or disable specific types of messages in the game, it would be nice to add support for obituaries (as found in the ZDoom family of ports), but have them disabled by default. The obituary strings should be modifyable by DEHACKED. There are default strings available in the old Doom wiki (and in the GZDoom sources, I guess):
https://doom.fandom.com/wiki/ZDoom_obituaries

Since our player "object" does not distinguish between different sexualities, I think it is safest to always refer to them as they/them.

@fabiangreffrath
Copy link
Owner Author

@fabiangreffrath
Copy link
Owner Author

@fabiangreffrath
Copy link
Owner Author

@fabiangreffrath
Copy link
Owner Author

@rfomin what would you say, where is the best place to set the player names from the colors to the actual chosen names?

@rfomin
Copy link
Collaborator

rfomin commented Aug 23, 2023

@rfomin what would you say, where is the best place to set the player names from the colors to the actual chosen names?

I don't know. I found that very few Boom/MBF PWADs have obituaries in Dehacked, this feature might not be worth it.

@fabiangreffrath
Copy link
Owner Author

fabiangreffrath commented Aug 23, 2023

I don't know. I found that very few Boom/MBF PWADs have obituaries in Dehacked, this feature might not be worth it.

Do you mean the obituaries feature itself or just the part that replaces "player 1" or "green player" with their chosen name?

@rfomin
Copy link
Collaborator

rfomin commented Aug 23, 2023

Do you mean the obituaries feature itself or just the part that replaces "player 1" or "green player" with their chosen name?

I mean the feature itself. I know only two compatible PWADs where it has been used: Ancient Aliens and Doom 2 in Spain Only.

@fabiangreffrath
Copy link
Owner Author

I mean the feature itself. I know only two compatible PWADs where it has been used: Ancient Aliens and Doom 2 in Spain Only.

Okay, but we could nevertheless have "Vanilla" obituaries for multiplayer games. The feature doesn't only start to make sense if the strings got dehacked, right?

@rfomin
Copy link
Collaborator

rfomin commented Aug 23, 2023

The feature doesn't only start to make sense if the strings got dehacked, right?

Sure. Then I like the player colors better, vanilla doesn't have player names.

@fabiangreffrath
Copy link
Owner Author

What's the default color for obituaries in gzdoom?

@fabiangreffrath
Copy link
Owner Author

What's the default color for obituaries in gzdoom?

Seems that's gold, but we should make this configurable anyway.

@fabiangreffrath
Copy link
Owner Author

@fabiangreffrath fabiangreffrath self-assigned this Sep 6, 2023
fabiangreffrath added a commit that referenced this issue Sep 6, 2023
fabiangreffrath added a commit that referenced this issue Sep 7, 2023
* add obituaries

Fixes #1092

* add forgotten files

* cosmetics

* add Voodoo obituary

* enable by default, change default color

* special obituaries only for damaging slime and lava

* nicer formatting

* add forgotten DEH substitute for OB_VOODOO

* fix constness issue

* remove unnecesssary includes

* remove bogus comment

* ouch, add back net_client.h include
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants