Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on Chex intermission #1368

Merged
merged 1 commit into from Jan 4, 2024
Merged

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Jan 4, 2024

@fabiangreffrath
Copy link
Owner

What has happened here? The "You are here" patch doesn't fit on screen, so it iterates to find a new one, but there isn't any and so it crashed?

@fabiangreffrath
Copy link
Owner

What has happened here? The "You are here" patch doesn't fit on screen, so it iterates to find a new one, but there isn't any and so it crashed?

Similar, but the splash patch was actually at fault:
coelckers/prboom-plus@f92800d

Strange, I think I have played through Chex several times already with my son. 🤔

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 4, 2024

Strange, I think I have played through Chex several times already with my son. 🤔

It works for me in the RelWithDebInfo build, but crashes in the Release. With code like this, I don't think we should enable all compiler warnings 😉

@fabiangreffrath
Copy link
Owner

It works for me in the RelWithDebInfo build, but crashes in the Release. With code like this, I don't think we should enable all compiler warnings 😉

Or even more, so we have a chance to catch this stuff earlier. 😉

@rfomin rfomin merged commit a519206 into fabiangreffrath:master Jan 4, 2024
6 checks passed
@rfomin rfomin deleted the fix_chex branch January 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Crash to desktop with "Penultimate Breakfast"
2 participants