Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Walk Under Solid Hanging Bodies" from PrBoom+ #786

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

fabiangreffrath
Copy link
Owner

No description provided.

@fabiangreffrath fabiangreffrath marked this pull request as ready for review October 31, 2022 09:32
Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but to be honest I don't know much about this issue. Maybe we should combine all options of this type into one option "map fixes".

@fabiangreffrath
Copy link
Owner Author

Looks good to me, but to be honest I don't know much about this issue. Maybe we should combine all options of this type into one option "map fixes".

Hm, I don't think so. These changes are a bit too drastic, so I'd like to have them more fine-grained.

{
"hangsolid",
(config_t *) &hangsolid, NULL,
{0}, {0,1}, number, ss_enem, wad_no,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have collected some unrelated config keys with ss_enem category again. Will have to clean this up (probably only after this PR, though).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I always forget about it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the right category, btw?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the right category, btw?

ss_gen for "General" menu.

@fabiangreffrath fabiangreffrath merged commit c2f9c62 into master Nov 2, 2022
@fabiangreffrath fabiangreffrath deleted the hangsolid branch November 2, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants