Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove looping sounds quirk #973

Merged
merged 1 commit into from Apr 6, 2023
Merged

remove looping sounds quirk #973

merged 1 commit into from Apr 6, 2023

Conversation

fabiangreffrath
Copy link
Owner

No description provided.

rfomin
rfomin approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with DBP25 and others - no clicking.

@fabiangreffrath
Copy link
Owner Author

🥳

@fabiangreffrath
Copy link
Owner Author

One little issue remains, though. Since we are not qsort()ing our channels anymore, the last channel is not guaranteed to have the lowest priority (highest numerical priority value) of all. I should probably go back to the original WinMBF logic and save the channel with the lowest priority in the loop looking for an empty channel.

@rfomin
Copy link
Collaborator

rfomin commented Apr 5, 2023

I should probably go back to the original WinMBF logic and save the channel with the lowest priority in the loop looking for an empty channel.

Yes, I have seen this code in the git log. Not sure if this is correct, but I think we should go back to vanilla MBF if possible.

@fabiangreffrath
Copy link
Owner Author

MBF or WinMBF? They differ in details...

@fabiangreffrath
Copy link
Owner Author

MBF or WinMBF? They differ in details...

I guess haleyjd has a point in his changes, so I'll probably use the WinMBF implementation. It's where we came from anyway.

@fabiangreffrath fabiangreffrath merged commit 7338fec into master Apr 6, 2023
6 checks passed
@fabiangreffrath fabiangreffrath deleted the unloop_sounds branch April 6, 2023 05:29
@mikeday0
Copy link
Contributor

mikeday0 commented Apr 6, 2023

I experience significant clicking in DBP25 in the latest master (8058a80). Going to try to build an updated version of OpenAL (currently on 1.19.1) to see if that addresses the problem.

@rfomin
Copy link
Collaborator

rfomin commented Apr 6, 2023

I experience significant clicking in DBP25

Do you have Open AL Soft?
image

Maybe it only works so well on Windows.

@rfomin
Copy link
Collaborator

rfomin commented Apr 6, 2023

I know that OpenAL Soft is the most developed implementation right now. Also OpenAL can use SDL as output, which of course defeats the purpose. 😄

@fabiangreffrath
Copy link
Owner Author

Indeed, it clicks on Linux, with "OpenAL Soft". 😭

@mikeday0
Copy link
Contributor

mikeday0 commented Apr 6, 2023

Upgrading to OpenAL version 1.23.0 fixes the clicking for me.

@rfomin
Copy link
Collaborator

rfomin commented Apr 6, 2023

Upgrading to OpenAL version 1.23.0 fixes the clicking for me.

Great! Curious what the problem was, on Windows, no matter what I threw into it, I didn't hear a single click.

@fabiangreffrath
Copy link
Owner Author

Oh, right, debian is still on 1.19.1.

@fabiangreffrath
Copy link
Owner Author

Just checked, the clicking is present with libopenal-soft 1.19.1, but it's fixed with 1.21.1! 🎉

@fabiangreffrath
Copy link
Owner Author

Voila:
https://github.com/kcat/openal-soft/blob/9062721fa84322d794e9676974ad1a3e82913b91/ChangeLog#L311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfomin rfomin rfomin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabiangreffrath @rfomin @mikeday0