Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/release: Submodule checkout needed? #347

Closed
thetredev opened this issue Dec 13, 2022 · 2 comments · Fixed by #349
Closed

workflows/release: Submodule checkout needed? #347

thetredev opened this issue Dec 13, 2022 · 2 comments · Fixed by #349

Comments

@thetredev
Copy link
Contributor

thetredev commented Dec 13, 2022 •
edited
Loading

Line https://github.com/fabianishere/pve-edge-kernel/blob/master/.github/workflows/release.yml#L60 (job publish) forces submodule checkout, which I don't think is necessary for the workflow. So I'm guessing this line can be removed.
@fabianishere
Copy link
Owner

You are correct, the submodule checkout is not necessary for the publish job.

@thetredev
Copy link
Contributor Author

Alright, I'll create a PR.

thetredev added a commit to thetredev/pve-edge-kernel that referenced this issue Dec 13, 2022
@thetredev
Fix issue fabianishere#347
b1cafef 
Signed-off-by: Timo Reichl <thetredev@gmail.com>
@fabianishere fabianishere linked a pull request Dec 14, 2022 that will close this issue
Fix issue #347 #349
Merged
fabianishere pushed a commit that referenced this issue Dec 14, 2022
@thetredev
Do not perform submodule checkout on publish (#349)
6f8820f 
This change removes the submodule checkout when the package is in the publish phase.
We do not use the contents of the submodules during this phase.

Close #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #347 thetredev/pve-edge-kernel
2 participants
@fabianishere @thetredev