Disabling UBSAN due to instability on boot on some HW / module configurations #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream Ubuntu kernel enables UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on the hardware or module configuration. With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. Therefore, I believe it is worth disabling for now. Resolves fabianishere#164
fabianishere
force-pushed
the
ubsan_disable
branch
from
9c6dd5f
to
61be0a2
Compare
|
Thank you for your contribution! I agree with your assessment (and it seems the people from Ubuntu do to). Funnily enough, one of my machines running v5.14 actually crashed today, so that might have something to do with it. |
fabianishere
approved these changes
Sep 5, 2021
fabianishere
pushed a commit
that referenced
this pull request
Sep 5, 2021
The upstream Ubuntu kernel enables UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on the hardware or module configuration. With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. Therefore, I believe it is worth disabling for now. Resolves #164
fabianishere
added a commit
that referenced
this pull request
Sep 5, 2021
The upstream Ubuntu kernel enables UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on the hardware or module configuration. With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. Therefore, I believe it is worth disabling for now. Resolves #164 Co-authored-by: Andrii Moiseiev <amoiseiev@gmail.com>
fabianishere
pushed a commit
that referenced
this pull request
Nov 10, 2021
The upstream Ubuntu kernel enables UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on the hardware or module configuration. With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. Therefore, I believe it is worth disabling for now. Resolves #164 and #200
fabianishere
pushed a commit
that referenced
this pull request
Nov 10, 2021
The upstream Ubuntu kernel enables UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on the hardware or module configuration. With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. Therefore, I believe it is worth disabling for now. Resolves #164 and #200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #164
Problem statement:
Ubuntu's team decided to try and enable UBSAN on 5.14+ and 5.13.14+ builds, leading to boot issues on servers depending on modules used or hardware installed.
With hundreds of different kernel modules and thousands different configuration, this change in its current stage is high risk and questionable in general. These issues are impossible to predict and hard to troubleshoot. I believe it's worth disabling.
I reported it to Ubuntu kernel-team as well: https://lists.ubuntu.com/archives/kernel-team/2021-September/123828.html