Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CIRC, fix CI build, add lifetime annotations #252

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bump CIRC, fix CI build, add lifetime annotations #252

wants to merge 6 commits into from

Conversation

stefanlippuner
Copy link

@stefanlippuner stefanlippuner commented Sep 30, 2023 •
edited
Loading

Changes:

  • Bump CIRCT to llvm/circt@24d394b (already kind-of old by now :|)
    • Most changes were done by @maerhart, I only added a few missing libraries
  • Switch CI build to ninja. Somehow using makefiles and parallel build seems to cause errors on Ubuntu. The CIRCT build instructions also recommend ninja, so I think this should be ok.
  • Add missing lifetime annotations for trait objects (resolves issue Build fails due to type deduction #251)
  • Pin Rust toolchain version to v1.66
    • Building moore with v1.67 or newer results in stack overflows at runtime (e.g. when running the tests). I think fixing this can be deferred for now.
  • Change requirements for SV tests
    • Ignore error in common_cells (broken on master and here)
    • Add tests that were ignored due to issues that have since been resolved.

CI workflow run: https://github.com/stefanlippuner/moore/actions/runs/6361816938

maerhart and others added 6 commits June 1, 2023 17:59
@maerhart
Bump CIRCT
37f9596
@stefanlippuner
Add missing libraries
8fd4e59 
Build now works with rust 1.63 (when using backtrace = "=0.3.68")
@stefanlippuner
Use ninja to build llvm and circt, pin Ubuntu version in CI
3ece4eb 
Uing makefiles and parallel build seems to cause errors in CI.
@stefanlippuner
Add missing lifetime annotations for trait objects
8c4fbe9 
This caused compiler errors for rust >= 1.65
@stefanlippuner
Pin Rust toolchain version to v1.66
a825813 
Newer toolchains cause stack overflow errors in some tests. That may be related to
a memory alignment change in Rust v1.67 (rust-lang/rust#102750)
@stefanlippuner
test: Ignore error in common_cells (broken previously), remove old IG…
e92cd9b 
…NOREs

The common_cells test was already failing as of 37f9596

The removed ignores referenced issues that have been closed and the tests
pass now.
@stefanlippuner
Copy link
Author

stefanlippuner commented Sep 30, 2023 •
edited
Loading

@maerhart I picked up 37f9596 from your branch. Are you ok with merging that (with the addition of my fixes in 8fd4ee59)?

@maerhart
Copy link
Collaborator

I picked up 37f9596 from your branch. Are you ok with merging that (with the addition of my fixes in 8fd4ee59)?

Of course, thanks for picking it up!

@stefanlippuner stefanlippuner marked this pull request as ready for review October 1, 2023 06:56
@fabianschuiki
Copy link
Owner

Awesome, thanks a lot 🎉! Let me kick off the CI run here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanlippuner @maerhart @fabianschuiki