Informer gen keyfuncs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
informer-gen-keyfuncs
branch
7 times, most recently
from
e148e4b
to
9691028
Compare
Use variadic option function instead of struct handle defaulting of sharedIndexInformer.index add godocs
fabianvf
force-pushed
the
informer-gen-keyfuncs
branch
from
9691028
to
bd67f11
Compare
ncdc
reviewed
Jun 2, 2022
| @@ -83,6 +85,8 @@ type NewInformerFunc func({{.clientSetPackage|raw}}, {{.timeDuration|raw}}) cach | |||
| type SharedInformerFactory interface { | |||
| Start(stopCh <-chan struct{}) | |||
| InformerFor(obj {{.runtimeObject|raw}}, newFunc NewInformerFunc) {{.cacheSharedIndexInformer|raw}} | |||
| ExtraIndexers() {{.cacheIndexers|raw}} | |||
| KeyFunction() {{.cacheKeyFunc|raw}} | |||
There was a problem hiding this comment.
One comment from Jordan that I didn't mention before (sorry!) was trying to avoid needing to do this. We should see if we can adjust the default informer functions in some way so this isn't needed.
There was a problem hiding this comment.
think I addressed it. I added variadic options to the NewInformerFunc type. I was unable to find a case of someone defining their own implementation of that function so as long as we don't take out the redundant resyncPeriod all callsites should remain unbroken. I could also create a parallel implementation with a NewInformerFuncWithOptions and InformerForWithOptions but it seemed a little heavy considering most of that is internal generated code.
fabianvf
force-pushed
the
informer-gen-keyfuncs
branch
from
bd67f11
to
ea717b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.