✨ Stop if there is no tags in repo and release option is absent

[charlyx]

Hello @fabienjuif 👋

This is my very first Rust contribution! 🎉

After reading your code I think I've added the message at the right position. Please tell me if I'm wrong!

At first I was going to use panic! as I want to display a message and stop the program but the result is not human-friendly.
I could have used human_panic but I didn't want to introduce a new dependency without talking to you first.

So here I am with a simple solution.

Happy to discuss! 😄

Fix #14

[fabienjuif]

Nice :)

I read that tomorrow, if I forgot just ping me!

About the new dependencies, I think this is not a panic message since your message is here to help human using the CLI.
So I think you did the right choice!

[fabienjuif]

If we wan't the error to be printed as a CLI, we should add it in main.rs, line 38 maybe, juste before changelog.to_markdown(

But if we wan't the error to be printed as a lib, the message is fine where you put it.
Except that a process.exit() in a lib is not fine :)
We should either:

1. Let the message in CLI only (see first paragraph)
2. Returns a Result<String, Err> in the to_markdown method

[fabienjuif]

What do you think?, I think the 1. is good enough

[charlyx]

Haha! I haven’t thought about the lib to be honest... 😢 But yeah, I have thought of returning a type Result. Let’s do it. I like it 😊 I guess we’ll have to deal with the error in the main then?

…

On 25 Feb 2019, at 8:57 AM, Fabien JUIF ***@***.***> wrote: What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[fabienjuif]

Yes!
Thats it, you can use pattern matching in the main.rs if you want.

https://doc.rust-lang.org/std/result/enum.Result.html

[fabienjuif]

Is there a way to expose the std::Error instead of our custom one?

[fabienjuif]

Thank you master, I publish it right now in 0.4.0