Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path of bower_component is wrong #1

Closed
jaceju opened this issue Mar 25, 2015 · 2 comments
Closed

Path of bower_component is wrong #1

jaceju opened this issue Mar 25, 2015 · 2 comments

Comments

@jaceju
Copy link

jaceju commented Mar 25, 2015

After wiredep, the template would be:

<!-- bower:css -->
<link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.css" />
<!-- endbower -->

But the full URL of bootstrap.css would be http://homestead.app/auth/bower_components/bootstrap/dist/css/bootstrap.css when I browse http://homestead.app/auth/login, it is wrong.

I found the pattern of ignorePath should be /(\..\/)*public/, not /(\..\/)*public\//, I fixed it in gulpfile.

Do I miss something?

@FabioAntunes
Copy link
Owner

I'm going to fix it, since this already happened to me, instead of injecting this:

<!-- bower:css -->
<link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.css" />
<!-- endbower -->

That is relative to actual path, from now on it will inject bower_components with the asset() helper function

<!-- bower:css -->
<link rel="stylesheet" href="{{ asset('bower_components/bootstrap/dist/css/bootstrap.css') }}" />
<!-- endbower -->

FabioAntunes added a commit that referenced this issue Mar 25, 2015
@jaceju
Copy link
Author

jaceju commented Mar 25, 2015

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants