Make get_active_theme a manager method instead of class method

[mounirmesselmeni]

refs #229

[codecov]

Codecov Report

Base: 97.58% // Head: 97.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8bcc455) compared to base (186e78b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   97.58%   97.57%   -0.02%     
==========================================
  Files          36       36              
  Lines         414      412       -2     
==========================================
- Hits          404      402       -2     
  Misses         10       10              

Flag	Coverage Δ
unittests	97.57% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
admin_interface/models.py	100.00% <100.00%> (ø)
...min_interface/templatetags/admin_interface_tags.py	95.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[fabiocaccamo]

@mounirmesselmeni thank you very much for this PR!

[fabiocaccamo]

@merwok @mounirmesselmeni out of scope:

Do you know (if possible) how to avoid CI failures caused by Codecov if coverage delta < N ?

[merwok]

There must be a setting in the project dashboard or config file or upload command to define an acceptable threshold.

[fabiocaccamo]

It's what I expected, but I don't find it...

[fabiocaccamo]

Do you think it is a bad idea?

[merwok]

I haven’t really looked at codecov in some years, only used it for a specific client.
I never felt the need to use such a service for my own projects, for me it’s fine to require 100%, ignore some files or blocks as needed, see missing lines in CI output (and locally using coverage html when adding new things).
With the recent security problems related to codecov I am even less incliined.

But docs are here: https://docs.codecov.com/docs/common-recipe-list and https://docs.codecov.com/docs/commit-status

[fabiocaccamo]

Thank you!